if you are stock I'd shift a little before redline (about 300 rpms or so)
if you have some mods which allow the car to breathe better, then shifting at redline would be more useful because the engine's top end isn't being chocked down so much anymore. I think you can feel the difference after just a CAI and exhaust.